sonar-puppet icon indicating copy to clipboard operation
sonar-puppet copied to clipboard

Support 'custom file server mount point' (by configuration)

Open axel3rd opened this issue 7 years ago • 2 comments

Hello,

The puppet:PuppetURLModules is a relevant rule, but as explain in linked Puppet File Server Guide:

Generally, files are stored in modules. But if you need to serve larger files that shouldn’t be in source control or shouldn’t be distributed with a module, you can make a custom file server mount point and let Puppet serve those files from another directory.

In a company with large Puppet Master and some categorizations, this customization could be useful.

In complement of #150 ('modules' pattern & variables), having some SonarQube plugin configuration about that could allow this case:

source => "puppet:///company-foo/...
source => "puppet:///company-bar/...

Formalization with SonarQube plugin property usage:

@Properties({ @Property(
    key = sonar.puppet.mount.points, 
    name = "Adding file server mount points", 
    type = PropertyType.STRING, 
    description = "Comma-separated list of additional mount points for 'PuppetURLModules' check; in complement of 'modules' and variable usage."
) })

I can provide a PR if feature considered as relevant.

Best regards

axel3rd avatar May 23 '17 16:05 axel3rd

+1

coxifred avatar May 24 '17 09:05 coxifred

Formalization with SonarQube plugin property usage: @Properties({ @Property(

Perhaps a @RuleProperty is more simple ...

axel3rd avatar Aug 18 '17 23:08 axel3rd