Iwan Budi Kusnanto

Results 90 comments of Iwan Budi Kusnanto

> zos right now supports also HDD nodes, I'm believe sequential nature of HDD would have the performance impacted (worse) with the concurrency I assume it won't happen because the...

This PR might not be needed if we want to implement bcachefs differently from the start.

> on the peer_check_interval i also wonder why we have separate dead peer check on peer manager & router. Maybe we could merge the PeerManager's `peer_check_interval` with Router's `check_for_dead_peers` https://github.com/threefoldtech/mycelium/blob/74719ba7cacb96e2d9251ce57760474e6973a14e/mycelium/src/peer_manager.rs#L404...

Doesn't mean to be picky on the wording part. > We need to implement A/B Testing functionality for ZOS upgrades to facilitate controlled experiments on different nodes or farms. The...

Oh okay, feature flag/toggle then

> controlled rollout OK, so it is clear that we want is controlled rollout.

> The node is apparently submitting an invalid IP address to TF Chain (the error is triggered by a [simple check](https://github.com/threefoldtech/tfchain/blob/1c787e1918a2d75e0e0c3db74d82f661c63f06e9/substrate-node/pallets/pallet-tfgrid/src/interface.rs#L133) that the address is longer than seven characters) @scottyeager...

> Probably the IP address itself is empty. if possible, give the result of this command ```console ip addr ```

> but I still think it's worth looking into how we can prevent it from happening again. It would be tricky to fix/prevent something when we don't know the root...

From what i can see, the error could be caused by empty/invalid IP address of the bridge. Some improvements we probably could do is improving this part https://github.com/threefoldtech/zos/blob/9998be1c6c66c387c106bdee7232cfe7f768ccf4/pkg/registrar/register.go#L113-L116 1. change...