Ian Wahbe

Results 264 comments of Ian Wahbe

Hey @nishanths. Thanks for the excellent feedback. I have addressed your comments.

Thanks for the feedback. I addressed it and am ready for another round of review. I really appreciate your patience here.

> Possibly on an unrelated note, can you clarify what you mean by the following quote? Do you mean having had to add `//exhaustive:ignore` at multiple switch statements that switched...

I agree that emacs doesn't have good out of the box support for JSON, though it doesn't have good out of the box support for much else either in my...

Hey @taku0, I appreciate the PR. My plan is to review this PR after #47. Moving away from long lines makes sense given how badly emacs handles them.

Design doc is https://docs.google.com/document/d/1CpOmG3QNtY1fGX1vuXsb5nehr40lomknbJtjWivjBhM/edit#

This will require a change in schema generation for pulumi-azure-native at the very least, as it generates types like this: ```json "azure-native:datafactory:AzureDatabricksDeltaLakeSink": { "description": "A copy activity Azure Databricks Delta...

Is there an associated issue in pulumi/pulumi to track the performance problem?

I can confirm that we still have the same issue with `v5.42.0`. This is still a dangerous change: ```patch import * as aws from "@pulumi/aws"; -const provider = new aws.Provider("p",...

Hey @ericlin-nz. Thanks for reporting this issue. I'm sorry this isn't working as intended. --- May be related to https://github.com/pulumi/pulumi-aws-native/issues/415. It's a similar error and the same resource.