react-native-image-crop-picker icon indicating copy to clipboard operation
react-native-image-crop-picker copied to clipboard

Fails to build with Android 12

Open jzxchiang1 opened this issue 2 years ago • 2 comments

Version

Tell us which versions you are using:

  • react-native-image-crop-picker v0.37.2
  • react-native v0.64.2

Platform

Tell us to which platform this issue is related

Android

Expected behaviour

Should build fine.

Actual behaviour

Error is:

Apps targeting Android 12 and higher are required to specify an explicit value for `android:exported` when the corresponding component has an intent filter defined. See https://developer.android.com/guide/topics/manifest/activity-element#exported for details.

It's fixed when I manually patch the library to add a android:exported="true" line here:

https://github.com/ivpusic/react-native-image-crop-picker/blob/2b95b88f0b45025cccea0d39be582ff4cf311d1e/android/src/main/AndroidManifest.xml#L26

Steps to reproduce

  1. Upgrade compileSdkVersion and targetSdkVersion to 31 in the main app's build.gradle.

  2. Run npm run android.

  3. See error.

Attachments

jzxchiang1 avatar Dec 04 '21 19:12 jzxchiang1

Is there any update on SDK 12 Support?

e-pradeep avatar Jul 11 '22 07:07 e-pradeep

Hi there! I posted about this in another issue: https://github.com/ivpusic/react-native-image-crop-picker/issues/1428#issuecomment-1240053429

Hope that helps!

mattjbrill avatar Sep 09 '22 20:09 mattjbrill