react-native-image-crop-picker icon indicating copy to clipboard operation
react-native-image-crop-picker copied to clipboard

Published 20 hours ago • verified publisher icon ivpusic

WIP: Support for maximum video duration (maximumVideoDuration)

Open mrousavy opened this issue 4 years ago • 11 comments

This PR adds support for a new property in the options: maximumVideoDuration.

  • [x] Add types for the JS/TS API
  • [x] Implement Android via openCamera
  • [ ] Implement Android via openPicker
  • [x] Implement iOS via openCamera
  • [ ] Implement iOS via openPicker

@ivpusic Could you maybe take a look at the openPicker implementations and help me figure out what's needed to get those working as well?

mrousavy avatar Nov 13 '20 12:11 mrousavy

@Deodes I have implemented iOS, Android and JS/TS part for openCamera. As stated in my original post, I need help from @ivpusic to get the same feature working for openPicker. If you need this feature feel free to take a look at the code and try implementing it yourself.

mrousavy avatar Jun 02 '21 12:06 mrousavy

any updates on this feature? will this be merged? Thanks

melbin97 avatar Dec 03 '21 03:12 melbin97

Any updates?

champikamendis avatar Jan 06 '22 14:01 champikamendis

need this feature badly! any updates?

shekharskamble avatar Jan 12 '22 03:01 shekharskamble

need this feature badly! any updates?

same! adding just the changes via patch-package right now has been clutch. love to get this merged!

jasongaare avatar Mar 18 '22 04:03 jasongaare

@mrousavy @ivpusic can we merge this?

felippepuhle avatar Mar 22 '22 19:03 felippepuhle

Any updates on this?

nica0012 avatar Oct 04 '22 15:10 nica0012

Question on how this would work.

Say the video is 1m30s. If the maxDuration is 15 seconds, when they select the video how will this 15 seconds be determined?

Will the user be able to trim to their desired 15 seconds of the video?

Cheers.

nica0012 avatar Oct 27 '22 14:10 nica0012

need this feature badly! any updates?

same! adding just the changes via patch-package right now has been clutch. love to get this merged!

How can I use this fixes in my app for this features?

Jahanzeb009 avatar Jan 24 '23 10:01 Jahanzeb009

any update?

harleenarora avatar Jul 23 '23 19:07 harleenarora

Is this going to get merged? or any other prop added lately for a max duration?

nik098 avatar Feb 15 '24 22:02 nik098