express-rate

express-rate copied to clipboard

Unit test fixup

1

I've redone the tests in Mocha with Supertest as a harness for Express. I think I've addressed a couple of problems that the tests had. I hope this may be...

dougluce

Rate limit all requests across the app

2

I tried to do app.use(limiterMiddleware) but I got some crazy errors I don't understand.

factoidforrest

PKuebler

420 is not commonly used for over rate limit. Suggest follow RFC 6585 and use 429 - Too Many Requests. Also, the original one did not set status code but...

qmlab

As transactions aren't supported by twemproxy, this patch removes multi() and makes express-rate compliant with twemproxy.

qzaidi

This message was given when rate limiting is hit: ``` express deprecated res.json(status, obj): Use res.status(status).json(obj) instead node_modules/express-rate/lib/rate.js:61:17 ``` The deprecation is mentioned in https://github.com/strongloop/express/releases/tag/4.7.0 Also update the docs and...

dougluce

AmitThakkar

Example with memory instead of redis?

3

I think it could be helpful!

PunkChameleon

Flush out old logs that have expired (MemoryRateHandler)

3

Express-rate should flush out very old remote logs that have expired (redis does that for you). One alternative is to use [node-cache](https://github.com/ptarjan/node-cache), an in-memory cache with a put = function(key,...

palmerabollo

X-RateLimit-Reset

2

Hi, everything works great (thank you!) except that I get a 13-digit timestamp in my header, and I'm not sure that it's then setting the resetTime correctly. So I assume...

Xeus