gulp-typescript icon indicating copy to clipboard operation
gulp-typescript copied to clipboard

Published 20 hours ago • verified publisher icon ivogabe

WIP add useFileCompiler setting

Open mheiber opened this issue 5 years ago • 8 comments

enables getting type-checking while enforcing --isolatedModules

fix https://github.com/ivogabe/gulp-typescript/issues/613

mheiber avatar May 28 '19 16:05 mheiber

could use some advice on this: https://github.com/ivogabe/gulp-typescript/issues/613#issuecomment-496597930

mheiber avatar Jun 04 '19 12:06 mheiber

Hi Max, thanks for your PR. Sorry, I have not yet had time to look at your work, O hope to do that this evening or tomorrow.

ivogabe avatar Jun 04 '19 13:06 ivogabe

No rush, and thanks for your time

mheiber avatar Jun 04 '19 15:06 mheiber

closing, will reopen after incorporating changes

mheiber avatar Aug 16 '19 11:08 mheiber

Hi Max, have you had time to look into this? Or shall I proceed with this work?

ivogabe avatar Nov 10 '19 12:11 ivogabe

Apologies, I had to put this aside as we switched to a different solution. I can tidy this up next Sunday, but I understand if you would prefer to take over from here: whatever works.

Thanks again for your feedback!

mheiber avatar Nov 11 '19 21:11 mheiber

No problem, I also had some other things to do. No hurries, would be great if you could make some time next Sunday!

ivogabe avatar Nov 11 '19 21:11 ivogabe

Hi @ivogabe , I'm sorry, but I think I'll have to orphan this PR.

It started with a single new flag, but triggered a large refactor of the public API that I'm having trouble fitting in my head, given all the overloads and optional arguments.

I'm no longer using gulp-typescript, so don't want to be a bad user that does a drive-by PR that has such cascading affects on tests, docs, and the future maintainability of the project.

Thanks for your work on gulp-typescript, and apologies for bailing!

mheiber avatar Nov 21 '19 12:11 mheiber