audiomentations icon indicating copy to clipboard operation
audiomentations copied to clipboard

Published 20 hours ago • verified publisher icon iver56

Change default p in Trim from 0.5 to 1.0

Open iver56 opened this issue 2 years ago • 4 comments

For consistency. Because other transforms have 0.5 as the default.

iver56 avatar Mar 14 '22 15:03 iver56

Also change top_db default from 20 to 30 because 20 was too aggressive. librosa's default is 60.

iver56 avatar Mar 18 '22 07:03 iver56

Should I change this now, or it will be better to keep old values with warnings for now?

atamazian avatar May 18 '22 13:05 atamazian

I will create a new release later (probably a few months from now) where the default is changed. Then this issue can be closed.

iver56 avatar May 18 '22 14:05 iver56

OK

atamazian avatar May 18 '22 14:05 atamazian