ASP.NET-MVC-Lambda-Expression-Helpers icon indicating copy to clipboard operation
ASP.NET-MVC-Lambda-Expression-Helpers copied to clipboard

Updating references to NuGet packages

Open SvenAelterman opened this issue 4 years ago • 7 comments

I've mainly updated the references to the latest stable versions of everything. I've also done a few things with Code Analysis to address or suppress rules.

I am open to your feedback and modifications to my PR.

If you're still maintaining this project, I'd appreciate the merge and a release of an updated NuGet package? Thanks!

SvenAelterman avatar Oct 08 '19 14:10 SvenAelterman

Why hasn't this been merged in yet?

xantari avatar Jul 08 '20 12:07 xantari

I haven't had a chance to update the PR yet as requested by the maintainers. I know it needs to be done though.

SvenAelterman avatar Jul 08 '20 12:07 SvenAelterman

I haven't had a chance to update the PR yet as requested by the maintainers. I know it needs to be done though.

Hey, @SvenAelterman . If you are OK, I can make some time during the weekend to address all PR comments so we can close this PR and release a new version.

vladislav-karamfilov avatar Aug 17 '20 19:08 vladislav-karamfilov

@vladislav-karamfilov Yes, please make the modifications as you see fit.

SvenAelterman avatar Aug 28 '20 23:08 SvenAelterman

@vladislav-karamfilov Yes, please make the modifications as you see fit.

Hey, @SvenAelterman! I finally had the time to address the CR comments. I opened a PR (https://github.com/Sorrell-Solutions/ASP.NET-MVC-Lambda-Expression-Helpers/pull/2) to your fork's master and when you merge it, we'll be finally able to merge this PR and release a new NuGet package version. Thank you! :)

vladislav-karamfilov avatar Sep 27 '20 19:09 vladislav-karamfilov

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

:x: SvenAelterman
:x: vladislav-karamfilov
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Sep 27 '20 20:09 CLAassistant

@vladislav-karamfilov I've just approved your PR into my forked repo.

SvenAelterman avatar Sep 27 '20 20:09 SvenAelterman