Ivar Conradi Østhus

Results 106 comments of Ivar Conradi Østhus

We tested this change in out demo-environment and it has broken the email handling. It turns out escaping the full url will not create a valid url for the mail...

This SDK is not meant to be used in a browser environment. Have you seen Unleash Proxy?https://docs.getunleash.io/sdks/unleash-proxy

With the proxy you already have a browser sdk with a react example. https://github.com/unleash-hosted/unleash-proxy-client-js/tree/master/examples/react-app

...we can also expose the strategy implementations out of the Node SDK. But evaluating the strategies inside the browser means that you are exposing the full configuration to everyone. Which...

Registration is part of the metrics feature. It should be sufficient to disable metrics. Does that not work for you?

Hi there, I do not see how this can be a problem? You should only instantiate a single instance of the SDK in your application. The toggle collection itself is...

I really do not understand how this would be a problem? The private member field "toggleCollection" is a shared resource between the "reading thread" and the periodic background checker. If...

Thanks @checketts, I have read up on Java Threading and I think there is a potential risk here, but I assume in most cases it will correct itself fast enough...

Hi, setting environment in the SDK is not longer necessary as the environment is encoded in to the SDK token. It still exists for backward compatibility for enterprise customers. @thomasheartman...

> Hi @ivarconr, I see tests failed, but not sure it is due to my proposed change. Can the build be retriggered? @msusag you need to update the test snapshots...