SPStorkController icon indicating copy to clipboard operation
SPStorkController copied to clipboard

Adding feature to dismiss when pan on UIScrollView with UIStackView

Open Tavernari opened this issue 5 years ago • 10 comments

Hi, first of all, I have to say that your project is fantastic and works so smoothly.

This pull request is about to add a new feature, and this feature is about to dismiss this view using the pan on UIScrollView.

I hope it can help others with the same problem.

Tavernari avatar Jul 01 '19 19:07 Tavernari

Hi! Thanks!

You can describe bug which you fix? How see it bug?

ivanvorobei avatar Jul 01 '19 20:07 ivanvorobei

For example,

If you create a ViewController with a UITableView / UIScrollView ... top left right and bottom constraints 0 and it has a content size height greater than superview with bounce enabled, now if you reach the top when scroll the View didn't dismiss

So this feature is to add the dismiss behavior in that case.

Tavernari avatar Jul 01 '19 20:07 Tavernari

Example!

IMG_0381TRIM

Tavernari avatar Jul 01 '19 20:07 Tavernari

After this fix

After fix

Tavernari avatar Jul 01 '19 21:07 Tavernari

@ivanvorobei What do you think about this pull request?

Tavernari avatar Jul 04 '19 01:07 Tavernari

@Tavernari I think you did the right job, but I need time to check how this will change the job. I can get it in a couple of days.

ivanvorobei avatar Jul 04 '19 08:07 ivanvorobei

@Tavernari I tried to create an empty project according to your description and reproduce the problem, but I did not succeed. Can you make an empty project with this problem?

ivanvorobei avatar Jul 04 '19 08:07 ivanvorobei

@ivanvorobei my situation is happening because I am using UIScrollView + UIStackView, so I will try to repeat that situation in an empty project and then I will send you to check... thanks for your time

Tavernari avatar Jul 04 '19 21:07 Tavernari

@Tavernari any news?

ivanvorobei avatar Jul 10 '19 18:07 ivanvorobei

Any updates on this? I am having a similar situation if I present a navigation controller, I saw on different threads this is known to cause issues but was trying to make it work for my situation.

cwestMobile avatar Jul 25 '19 21:07 cwestMobile