SPStorkController icon indicating copy to clipboard operation
SPStorkController copied to clipboard

iOS 14 bug : swiping down the sheet do not pull down the sheet

Open blitzvb opened this issue 4 years ago • 11 comments

Bug:

When you swipe down the view, it do not pull down gradually the sheet. When you swipe down enough it will close it suddenly. It was working great before and the bug appear only on iOS 14.

Code used :

`

    let transitionDelegate = SPStorkTransitioningDelegate()
    transitionDelegate.storkDelegate = navController
    transitionDelegate.customHeight = viewController.panelHeight
    transitionDelegate.confirmDelegate = navController
    navController.transitioningDelegate = transitionDelegate

    navController.modalPresentationStyle = .custom
    
    self.topNavigationController().present(navController, animated: true, completion: nil)`

blitzvb avatar Sep 21 '20 07:09 blitzvb

У меня аналогичная проблема в iOS 14. Будет ли исправление данного бага?

Amondus avatar Oct 08 '20 08:10 Amondus

the same

gumenuk39 avatar Oct 12 '20 14:10 gumenuk39

I can confirm this is also happening for me on ios 14. For me, the scroll view itself seems to be "stuck". Scrolling up does not scroll the view anymore.

jhk115 avatar Oct 12 '20 23:10 jhk115

It's also happening to me, you can only see the indicator that it's moving and the opacity behind the screen is being reduced. It just dimissess the view controller if dragged down enough.

sevgjan avatar Nov 11 '20 09:11 sevgjan

If you guys have the luxury to target iOS 13, I recommend just rolling with the native modal. It was a painless switch.

jhk115 avatar Nov 11 '20 17:11 jhk115

@jhk115 agree

ivanvorobei avatar Nov 11 '20 19:11 ivanvorobei

@jhk115 I agree, and for most of the part I believe we all do that. But @ivanvorobei has done an amazing job with possibilities for height customization, close button, indicator, etc. which makes us prefer to use this library.

sevgjan avatar Nov 20 '20 12:11 sevgjan

It's also happening to me only on iOS 14, solved my problem after setting it

        if #available(iOS 11.0, *) {
            tableView.contentInsetAdjustmentBehavior = .never
        } else {
            automaticallyAdjustsScrollViewInsets = false
        }

lyimin avatar Dec 08 '20 10:12 lyimin

This is happening because SPStorkPresentationController containerViewWillLayoutSubviews is setting the presented view controller's frame to frameOfPresentedViewInContainerView when pan gesture changed.

tibo9 avatar Dec 21 '20 09:12 tibo9

@ivanvorobei Any updates?

Rogue85 avatar Jan 23 '22 22:01 Rogue85

This is happening because SPStorkPresentationController containerViewWillLayoutSubviews is setting the presented view controller's frame to frameOfPresentedViewInContainerView when pan gesture changed.

Comment out these few lines fixes the problem. @tibo9 Did you find any side effects doing so? Thanks in advance.

davidleee avatar Mar 21 '22 09:03 davidleee