ember-cli-d3-shape icon indicating copy to clipboard operation
ember-cli-d3-shape copied to clipboard

Proposal: rename this package to ember-cli-d3-shim

Open ivanvanderbyl opened this issue 9 years ago • 5 comments

Considering this now just wraps [email protected], I think it's time to deprecate ember-cli-d3-shape and release [email protected].

This would require notifying everyone who is using this as a dependency, which thankfully is only 4 projects

ivanvanderbyl avatar Jul 19 '16 14:07 ivanvanderbyl

This would require notifying everyone who is using this as a dependency, which thankfully is only 4 projects

There are probably some private projects that use this :)

Also, there's also a d3-shim (https://github.com/brzpegasus/ember-d3). Do you see a compelling reason to make another library?

mike-north avatar Jul 22 '16 03:07 mike-north

No, I'd like to either combine this with ember-d3 or ember-cli-d3, however the latter is not just a loader, it includes some helpers and components which should be part of a graphing addon.

So to help reduce confusion about what this does, I'd like to get rid of the -shape in the name :)

ivanvanderbyl avatar Jul 22 '16 07:07 ivanvanderbyl

I'm sure @mingcodes would have no objection to using a common shim in ember-cli-d3 to actually import the library and add it to the asset pipeline. His library overlaps a bit with maximum plaid, but as you say this is the "graphing addon" layer -- not the uninteresting "import a third party library" layer.

mike-north avatar Jul 22 '16 07:07 mike-north

I'm really excited by all the advances made in charting and Ember. I like the idea of renaming this package. We are currently moving away from the ember-charts library to more customized charts and the Ember addon d3 space is confusing as to what each package actually does.

mrosenberg avatar Jul 25 '16 12:07 mrosenberg

@mrosenberg we're working towards making the ecosystem more consistent. It looks like this library will be merged in to ember-d3 soon: https://github.com/brzpegasus/ember-d3/pull/8

ivanvanderbyl avatar Jul 25 '16 15:07 ivanvanderbyl