rtl88x2bu icon indicating copy to clipboard operation
rtl88x2bu copied to clipboard

Compilation error on last ubuntu update

Open koranten2 opened this issue 2 years ago • 2 comments

CC [M] /mnt/.../rtl88x2bu/rtl88x2bu/os_dep/linux/wifi_regd.o /mnt/.../rtl88x2bu/rtl88x2bu/os_dep/linux/wifi_regd.c: In function ‘rtw_regd_init’: /mnt/.../rtl88x2bu/rtl88x2bu/os_dep/linux/wifi_regd.c:409:36: error: ‘REGULATORY_IGNORE_STALE_KICKOFF’ undeclared (first use in this function) 409 | wiphy->regulatory_flags |= REGULATORY_IGNORE_STALE_KICKOFF; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /mnt/.../rtl88x2bu/os_dep/linux/wifi_regd.c:409:36: note: each undeclared identifier is reported only once for each function it appears in make[2]: *** [scripts/Makefile.build:260: /mnt/.../rtl88x2bu/rtl88x2bu/os_dep/linux/wifi_regd.o] Error 1 make[1]: *** [Makefile:2026: /mnt/.../rtl88x2bu/rtl88x2bu] Error 2 make[1]: Leaving directory '/usr/src/linux-headers-6.2.0-36-generic' make: *** [Makefile:2479: modules] Error 2

The above compilation error happened on last ubuntu 22.04 update. It was compiled successfully a month ago. Please, fix this issue!

koranten2 avatar Oct 31 '23 20:10 koranten2

Same Exact issue here

bigjoncoop avatar Nov 03 '23 04:11 bigjoncoop

This small patch fix the compilation problem on kernel 6.5.0 (Ubuntu 23.10), it is working afterwards but I'm not sure at all about implications. Will try to use it a bit and see.

diff --git a/os_dep/linux/wifi_regd.c b/os_dep/linux/wifi_regd.c
index 81e1dc7..db8846c 100644
--- a/os_dep/linux/wifi_regd.c
+++ b/os_dep/linux/wifi_regd.c
@@ -405,7 +405,7 @@ int rtw_regd_init(struct wiphy *wiphy)
 	wiphy->regulatory_flags &= ~REGULATORY_DISABLE_BEACON_HINTS;
 #endif
 
-#if (LINUX_VERSION_CODE >= KERNEL_VERSION(3, 19, 0))
+#if (LINUX_VERSION_CODE >= KERNEL_VERSION(3, 19, 0) && LINUX_VERSION_CODE < KERNEL_VERSION(6, 5, 0))
 	wiphy->regulatory_flags |= REGULATORY_IGNORE_STALE_KICKOFF;
 #endif

Side note: while compiling, there are quite some warnings now, not sure which ones are real and which ones are not, I'll try to take a look if and when my little knowledge assists me.

Dav1d23 avatar Nov 09 '23 09:11 Dav1d23