react-native-compressed-jsbundle icon indicating copy to clipboard operation
react-native-compressed-jsbundle copied to clipboard

Published 20 hours ago • verified publisher icon ivanmoskalev

brotli integration is outdated

Open SaruwatariSagittario opened this issue 2 years ago • 10 comments

Hi, really interested with your concept especially you mentioning regarding AppClip size with ReactNative which is the one I kinda developing right now. But when i tried to implement it i seem outdated with its integration with brotli. (even the example project also has the same issue). I tried to tweak it my co-worker but still cannot found the resolution. Could you maybe update this integration ? Thanks.

SaruwatariSagittario avatar Apr 08 '22 10:04 SaruwatariSagittario

Hi! Could you please clarify:

  • What is your React Native version?
  • What exact problems are you having? What steps are you taking and what errors pop up?

I'm currently away from my workstation, but I'll be able to test it myself later tonight.

ivanmoskalev avatar Apr 08 '22 12:04 ivanmoskalev

Hi, sorry for late reply the project i was trying to implement your library was in 0.66.4 version, the problem i am facing is that when i installed the library, i kept getting issue with the brotil thing.. it keep giving vector not found error. I even tried to run the example project given within this repo, also facing the same issue

SaruwatariSagittario avatar Apr 11 '22 03:04 SaruwatariSagittario

Thank you! I'm on it, will try to publish an update tonight

ivanmoskalev avatar Apr 13 '22 07:04 ivanmoskalev

Thanks a lot, appreciate the feedback

SaruwatariSagittario avatar Apr 13 '22 12:04 SaruwatariSagittario

Hi @SaruwatariSagittario! I was unable to reproduce the issue you mentioned on React Native 0.66.4. Could you please provide the actual error that appears in Xcode? You can just attach a screenshot.

ivanmoskalev avatar Apr 14 '22 06:04 ivanmoskalev

Hi, so these are the steps that happened when i tried to run the lib on my project environment... Initially i follow the steps of installations on your Readme, and i also run react-native link react-native-compressed-jsbundle, cause it seem missing the pod setting and linking to the project when i tried to run it initially. After that, i still got "'react-native-compressed-jsbundle/IMOCompressedBundleLoader.h' file not found"

Screen Shot 2022-04-14 at 16 18 21

after that, i tried to search manually but it seems there, so i tried to retype it on the appdelegate, but the one appear from auto suggestion instead "react-native-compressed-jsbundle-umbrella.h", i tried that and it seem can pass previous error

Screen Shot 2022-04-14 at 16 18 38

So, i tried run it again, and i got the vector not found issue

Screen Shot 2022-04-14 at 16 18 48

SaruwatariSagittario avatar Apr 14 '22 09:04 SaruwatariSagittario

@SaruwatariSagittario Could you try not executing the react-native link react-native-compressed-jsbundle? It seems to be messing things up. Please try this:

  • Follow the instructions in README and add the library.
  • Delete the ios/Pods folder and do pod install.
  • Show me the Podfile.lock file — it should have the library listed in it.

What kind of error did you have without the react-native link command?

ivanmoskalev avatar Apr 14 '22 12:04 ivanmoskalev

Hi, Sorry for really late reply.. I've been busy.. Ok, here's what i got when i tried cleanup fresh and retry to implement the installation guideline without react-native link Screen Shot 2022-04-19 at 11 32 06

what should i do from here ?

SaruwatariSagittario avatar Apr 19 '22 04:04 SaruwatariSagittario

Sorry, had a busy week. Something is misconfigured in your project, and I'm not sure what is it. Could you please make a small reproducible example, zip it up, and send me the zip? Maybe based on the example in this repo.

ivanmoskalev avatar Apr 24 '22 14:04 ivanmoskalev

I think there could be a correlation with use_frameworks! :linkage => :static.

tux2nicolae avatar Jul 02 '22 19:07 tux2nicolae