Ivan Ka

Results 538 comments of Ivan Ka

/label tide/merge-method-squash

Most likely this should be documented. Current pull-request is actually fixing, or moving to a new version of the format. So we going to have 3 formats - old -...

Sounds like a plan. We definitely need a deprecation plan for the old formats. I'd like to propose removing the 0.12 format immediately after the next release – I'm not...

I my simplify it or make it more step action based. Consider context, this change very high likely is going to be in next release cut. 1. We will do...

Got it, make sense. So potential action steps So action 1 1. Add new format, new flag. No need to support legacy or current formats, no need to create 2...

Do you mean we should do in this release > remove all the related flags and code related to old formats

Hi @kevinfrommelt are you still interested in this pull request? If yes, pls address the review. We also need a set of manual test steps using manifests and kubectl commands....

/help When not related example solution https://github.com/kubernetes-sigs/external-dns/pull/4573 for another provider Ideally this will required a global rate limiter