minimal icon indicating copy to clipboard operation
minimal copied to clipboard

Missing CRC32 at the rootfs compression

Open berlin4apk opened this issue 4 years ago • 3 comments
trafficstars

https://github.com/ivandavidov/minimal/blob/4393977a3c3fe7995d3b25a8a31d0644477768a2/src/10_pack_rootfs.sh#L18

Together with the ARCH specific BJC it will maybe compress a little bit better

See also https://github.com/torvalds/linux/blob/8baef6386baaefb776bdd09b5c7630cf057c51c6/scripts/xz_wrap.sh#L23

berlin4apk avatar Jul 23 '21 16:07 berlin4apk

Thank you for contributing to Minimal Linux Live! :)

github-actions[bot] avatar Jul 23 '21 16:07 github-actions[bot]

Thank you, that's a really nice observation!

I'll update the initramfs generation as per your suggestions shortly.

ivandavidov avatar Jul 23 '21 19:07 ivandavidov

I've added the crc32 check, but the --x86 optimization seems to be breaking the QEMU test, so I'm leaving it for now.

ivandavidov avatar Jul 23 '21 20:07 ivandavidov