Ivan Kozik

Results 148 comments of Ivan Kozik

Times to run dupespotter's test suite: as-is with many `re.sub`: 0.79 seconds combined regexps and a few `re.sub`s: 3 seconds combined regexps and `re2` with hand-rolled `sub`: 6 seconds Not...

Yeah, it would be nice to be able to customize dupespotter. But because most users won't, it probably makes sense to fix it in grab-site for more websites that anyone...

https://bugzilla.mozilla.org/show_bug.cgi?id=368519

Thanks! I will probably end up granting commit rights or ownership to contributors who send PRs that are mostly correct. A potential starter issue: https://github.com/ludios/grab-site/issues/145 suggests grab-site needs either [a...

We do not have a new maintainer yet (I don't know why "Looks like a maintainer was found." is above), but any github.com/ArchiveTeam person is authorized to give repo permissions...

Since I am somewhat occupied at the moment: would a grab-site user kindly test this and all of the new README instructions? Feel free to post feedback or code review.

Sorry for the delay, I had a lot of things going on. I followed the updated instructions (though I substituted `grab-network` with `gs-network`) on NixOS and got: ``` at@dev:/home/at/code/archiving/grab-site:docker-pr-2# docker...

Ah, I see `# Ensure that ./data exists and container has write privileges on volume`, so perhaps it should say ``` mkdir -p data ``` and then `-v $PWD/data:/data:rw` in...

When I start a `grab-site` container as per the Docker instructions, my containers appear to die before they do anything. `journalctl -b -u docker` shows ``` Aug 28 01:42:45 dev...

regarding the permissions, I am told "Fusl's Dockerfile simply ran grab-site as root inside the container, by the way. Not ideal, but since it's isolated to that container, probably fine?...