Facial-Recognition-Database-Management-System icon indicating copy to clipboard operation
Facial-Recognition-Database-Management-System copied to clipboard

Create profile editing page and form

Open ivan0313 opened this issue 4 years ago • 3 comments

Edit the ProfileDetails.jsx page to include a editing view so user can edit profile's name, and other details such as age, country, date of birth, etc...

ivan0313 avatar Sep 14 '21 03:09 ivan0313

Hey @ivan0313 ! I would like to work on this issue. I am participating in hacktoberfest.

TD-17 avatar Oct 14 '21 03:10 TD-17

Hey @ivan0313, so I went through the code regarding this issue. As I see it, the profile query is as follows:

query profile($profileId: ID!) {
    profile (profileId: $profileId) {
      id
      name
      facesCount
      thumbnail {
        location
        photo {
          id
          width
          height
        }
      }
    }
  }

We don't have fields like age, country, dob etc. If we add these new fields, we have to resolve them on the server side too.

Can you once expand on exactly which fields you would like to add to the profile and which ones to be editable? (As of now, only name is editable).

basil08 avatar Oct 30 '21 12:10 basil08

Hi @basil08

I'd suggest the scope first PR to add the feature of editing the profile name only. IMO this issue is complicated enough to be broken down into a few separate PRs.

Anyway, to answer your question, my idea is that there would be 3 kind of fields, the default fields, the user customized fields and tags (optional). Default fields would be attributes that users would frequently use to narrow their search, or common attributes of person profiles, for example sex, age (therefore dob), occupation, etc. Obvious we can only guess these attributes as we have no research or data to base our choices on. I'd suggest to start with the following fields first:

- sex
- date of birth
- country of origin

So these, along with the name (and thumbnail, but that's a separate issue) would be editable by user.

Another field, the user customized field, as the name states, can be customized by users. So I think we can create a profile attribute table that links n-to-1 to the profile table.

attribute value profile_id
favorite color blue 1
city NY 1
favorite color green 2

Finally, tags, this one is optional. Think Github topics, Instagram hashtags.

ivan0313 avatar Oct 30 '21 12:10 ivan0313