obsidian-day-planner icon indicating copy to clipboard operation
obsidian-day-planner copied to clipboard

fix: AM/PM will not be matched if it is part of the text

Open teisermann opened this issue 1 year ago • 2 comments

Fixes: #312

teisermann avatar Nov 24 '23 15:11 teisermann

Hello, @teisermann, thanks for taking the time to create this PR!

This seems like an overly complicated way to do something, that can be accomplished by updating this regex: https://github.com/ivan-lednev/obsidian-day-planner/blob/dfd17e7a29e85be5147d37aa2aec364ed2cbe390/src/regexp.ts#L16

to include something like this: image

What do you think?

ivan-lednev avatar Nov 26 '23 10:11 ivan-lednev

Hello @ivan-lednev Thanks for the feedback, i think your suggestion is wonderful and i adjusted my pr accordingly I used a non negative lookahead instead of the not-word matcher to avoid accidentally matching the - for timestamps

teisermann avatar Nov 26 '23 16:11 teisermann