obsidian-day-planner icon indicating copy to clipboard operation
obsidian-day-planner copied to clipboard

Day Planner Removing Characters while Typing

Open KyleKing opened this issue 3 years ago • 12 comments

Related to #107, but I wanted a new ticket to bump this issue since it is a critical bug

With the new Obsidian Live Preview mode, I'm noticing this issue more frequently. Obsidian is merging changes from the Day Planner causing whitespace between words to be removed as I'm typing

I still have Day Planner active, but I can no longer link the note to prevent Day Planner from modifying it

KyleKing avatar Jan 05 '22 12:01 KyleKing

I think this could be an issue with the regex stripping whitespace:

https://github.com/lynchjames/obsidian-day-planner/blob/c8d4d33af294bde4586a943463e8042c0f6a3a2d/src/constants.ts#L7-L8

But more generally I have mermaid and mark-TODOs-completed settings OFF (https://github.com/lynchjames/obsidian-day-planner/issues/92#issuecomment-864467907), so the plugin shouldn't be making modifications, but this logic appears to always write:

https://github.com/lynchjames/obsidian-day-planner/blob/c8d4d33af294bde4586a943463e8042c0f6a3a2d/src/planner-md.ts#L51-L80

Update: clarified technical thoughts a few times

KyleKing avatar Jan 05 '22 12:01 KyleKing

I have the same issue, thankfully the plugin is still usable with the legacy editor.

fnuttens avatar Jan 07 '22 10:01 fnuttens

Same issue here too, Windows, clean vault with only day planner loaded. Day planner issue with live preview

RobColes avatar Jan 25 '22 09:01 RobColes

Also experiencing this issue and it's causing a bunch of issues for me

himmAllRight avatar Feb 10 '22 13:02 himmAllRight

I am experiencing the same issue, have to switch to legacy editor to avoid it. Is there any other solution?

rxy0424 avatar Feb 26 '22 01:02 rxy0424

I am finding as a workaround that if I enter the details without a time, it leaves the text alone while I am typing, and then I go back and add the time to the beginning of the line when I'm done with the rest of it.

I have not done extensive testing on this but it is helping me while we wait for a proper fix.

RobColes avatar Mar 03 '22 00:03 RobColes

I think this could be an issue with the regex stripping whitespace:

@KyleKing can you not create a merge request for this?

This bug is so annoying....

grouchal avatar Mar 22 '22 08:03 grouchal

I don't think opening a PR would be worthwhile without input from @lynchjames first on what types of changes they would be open to

KyleKing avatar Mar 23 '22 00:03 KyleKing

Typing the time, then a full stop/period, then back-arrowing and typing the text before the full stop is also working for me.

RobColes avatar Mar 27 '22 22:03 RobColes

If the code fix works, it is possible to implement it locally. I have done this with another plug-in. Obviously this will be wiped if the plug-in is updated, but hopefully this would fix the issue anyway. And in the meantime...

Did you have a fix @KyleKing or have you just isolated the area of the issue?

RobColes avatar Mar 27 '22 22:03 RobColes

Did you have a fix @KyleKing or have you just isolated the area of the issue?

I only tried to isolate the issue and hadn't tried patching it locally yet

KyleKing avatar Mar 30 '22 23:03 KyleKing

I think this is demonstrably abandonware at this point and needs to be forked.

beansrowning avatar Apr 05 '22 17:04 beansrowning

Anyone had any progress on this one? This issue always pushes me from the extension. Anyone did a fork?

manuel-tiedtke avatar Feb 09 '23 10:02 manuel-tiedtke

I'm not using the plug in any more, so haven't looked further, sorry.

RobColes avatar Feb 10 '23 11:02 RobColes

I don't write type/javascript, so I can't be of much help. If someone was keen to work on the project, I'd be happy to sponsor.

beansrowning avatar Feb 10 '23 14:02 beansrowning

This should be fixed in the new version.

ivan-lednev avatar Sep 04 '23 17:09 ivan-lednev