invidious icon indicating copy to clipboard operation
invidious copied to clipboard

Published 20 hours ago • verified publisher icon iv-org

Add fallback to TvSimply client

Open Fijxu opened this issue 5 months ago • 5 comments

Depends on: https://github.com/iv-org/invidious/pull/5344

Uses the same order Invidious companion uses: https://github.com/iv-org/invidious-companion/blob/d0c4bb79ae4688d019fb281257859e334adb7d8b/src/lib/helpers/youtubePlayerReq.ts#L75

Fijxu avatar Jun 12 '25 05:06 Fijxu

IMO it's better to create just one PR instead of two.

unixfox avatar Jun 12 '25 06:06 unixfox

You're right. I'll fix it and test it later.

Fijxu avatar Jun 12 '25 19:06 Fijxu

I wasn't able to test it since Innertube didn't return signatureCipher to me. I added https://github.com/iv-org/invidious-companion/blob/d0c4bb79ae4688d019fb281257859e334adb7d8b/src/lib/helpers/youtubePlayerReq.ts#L92 to companion because when I was working on it, I got signatureCipher but not url.

Maybe we should really add some mocks, test data and crystal tests :/

Fijxu avatar Jun 12 '25 20:06 Fijxu

Technically there already are mocks and tests, there's just not enough of it and imo the current system is confusing to understand.

I don't fully understand it myself if I'm being honest but I believe you'll need to update iv-org/mocks with the mock json for this, pull the latest version of the submodule in the invidious repo, and then finally add a test for it here.

syeopite avatar Jun 12 '25 20:06 syeopite

I have taken the opportunity to remove the TV fallback here because of https://github.com/iv-org/invidious-companion/pull/157 TvSimply works fine enough on my instance (https://inv.nadeko.net)

Fijxu avatar Jun 15 '25 21:06 Fijxu

Merged with https://github.com/iv-org/invidious/commit/0308acb624657a30aff46417f848a2456c19025b

I'm not sure why Github's UI isn't marking this as merged.

syeopite avatar Aug 23 '25 11:08 syeopite