invidious icon indicating copy to clipboard operation
invidious copied to clipboard

Run Ameba in CI

Open syeopite opened this issue 8 months ago • 2 comments

Ameba has been technically apart of Invidious for a couple years now but its linting was never enforced. This PR changes that.

Following cases such as what was seen in #4709 it'd probably be a good idea to have Ameba check over everything, especially for basic mistakes.

And from the testing I've done its already been pretty helpful. For example a duplicated key in the i18next logic

https://github.com/iv-org/invidious/blob/1ae14cc22468ce6e0eb794752b113604b1d5582d/src/invidious/helpers/i18next.cr#L97-L98

This PR simply adds Ameba to the CI but doesn't actually fix any of the detected issues. I'd be opening more PRs in the near future to slowly address everything until Invidious is compliant.

syeopite avatar Jun 16 '24 21:06 syeopite