invidious icon indicating copy to clipboard operation
invidious copied to clipboard

Overhaul VideoJS dependency manager

Open syeopite opened this issue 1 year ago • 4 comments

  • Refactors code in the script

  • Simplify workarounds for dependencies with differing structure

  • Adds check for missing dependency files in assets/videojs/* in case of improper installation

  • Use native Crystal digest for checksum instead of system command

  • Don't clear the cache each time the script is, instead there's the parameter --clear-cache or the compile time flag clear_player_dependencies_cache when ran through Invidious.

  • Changes the default cache directly to be relative to the Invidious repo

  • Adds ability to use a custom NPM registry

  • Adds ability to change the cache directory

  • Allows using pre-existing downloaded tarballs of the dependencies

  • Logs checksum when validation fails.

  • Allows skipping checksum with the --skip-checksum parameter when calling the script directly, or the skip_player_dependencies_checksum compile-time flag when used through Invidious

syeopite avatar Feb 19 '24 01:02 syeopite

This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked.

github-actions[bot] avatar May 20 '24 01:05 github-actions[bot]

Is there something I can do to help get this back on track?

mk-pmb avatar May 25 '24 20:05 mk-pmb

This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked.

github-actions[bot] avatar Aug 24 '24 01:08 github-actions[bot]

I think all there's left to do is to add an npm section within the dependency file as to allow for downloading dependencies from other sources in the future.

syeopite avatar Aug 24 '24 01:08 syeopite