invidious icon indicating copy to clipboard operation
invidious copied to clipboard

Add chapters support to Invidious

Open syeopite opened this issue 2 years ago • 8 comments

This PR adds a chapters menu to the player control bar and a separate widget within the description to select chapters along with their thumbnail similar to what's on YouTube. See screenshots below.

Unfortunately, we can't segment the progress bar into multiple chunks like what YouTube does yet. VideoJS doesn't support this natively and it doesn't look like there are any extensions that does this.

Related: https://github.com/videojs/video.js/discussions/8235

chapters chapters widget

Closes chapters component of #2395

syeopite avatar Sep 19 '23 21:09 syeopite

Is there a reason you decided to create a completely new JSON API endpoint instead of just including it in the existing /api/v1/videos/{video id}? Seems like it will add extra unnecessary load on Invidious, as apps like FreeTube will be making the request for every video, but it'll frequently be pointless, as most videos don't have any chapters. Integrating it into the existing API response will make integration a lot easier.

absidue avatar Sep 20 '23 07:09 absidue

I'm not actually sure why I did that... good catch! Data for chapters should now be available in the standard /api/v1/videos/{video id} endpoint

syeopite avatar Sep 20 '23 19:09 syeopite

Thanks!

absidue avatar Sep 26 '23 05:09 absidue

Thanks!

absidue avatar Sep 26 '23 05:09 absidue

This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked.

github-actions[bot] avatar Apr 27 '24 01:04 github-actions[bot]

This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked.

github-actions[bot] avatar Jul 28 '24 12:07 github-actions[bot]