invidious icon indicating copy to clipboard operation
invidious copied to clipboard

Add feature of iframe api like youtube

Open bonjinnorenka opened this issue 1 year ago • 15 comments

I add feature of iframe embed control like youtube iframe api This feature fullfil part of #3705. This feature can't execute on IE11. But i didn't add all feature of youtube iframe api. I didn't unimplemented these functions and events. functiom all deprecated function player.cuePlaylist() player.loadPlaylist() player.getSphericalProperties() player.setSphericalProperties(properties:Object) player.nextVideo() player.previousVideo() player.playVideoAt(index:Number) player.setLoop(loopPlaylists:Boolean) player.setShuffle(shufflePlaylist:Boolean) player.getVideoLoadedFraction() player.getPlaylist() player.getPlaylistIndex()

event onPlaybackQualityChange onError this event not return exactory reason like youtube iframe api onApiChange

How to use. use invidious instead of YT in javascript.

bonjinnorenka avatar Aug 18 '23 02:08 bonjinnorenka

@AHOHNMYC Can you help me there? I'm not the best suited to review this PR!

SamantazFox avatar Aug 21 '23 21:08 SamantazFox

this commit description fc49ab2 I found some bug so fix and add partly function getVideoData found and fix bug in function load video data not reflect end secounds. if third party cookie not accepted ,volume reset to 100% when loaded new video

add hidden function getVideoData (not description in official iframe api reference but it can use on embed player) in this code, not all data available like official api, only can use video_id and title

bonjinnorenka avatar Aug 25 '23 16:08 bonjinnorenka

@SamantazFox yeah, I tried to do same about a year ago but was eaten by work... @bonjinnorenka I'll try to review your PR on this week. Thanks to your contribution!

AHOHNMYC avatar Aug 28 '23 07:08 AHOHNMYC

When server option save_player_pos is true, start secounds sometimes ignore in 2nd time or older load whatever query string start value is different that of fist load.

bonjinnorenka avatar Sep 06 '23 14:09 bonjinnorenka

I checked all functions.But please check work this program. I didn't unimplemented these functions and events. functions all deprecated function player.getSphericalProperties() player.setSphericalProperties(properties:Object) player.setShuffle(shufflePlaylist:Boolean) event onPlaybackQualityChange onApiChange

bonjinnorenka avatar Sep 07 '23 15:09 bonjinnorenka

I tried to fix points out and add support for playlist.So please review to this PR.

bonjinnorenka avatar Sep 07 '23 16:09 bonjinnorenka

@bonjinnorenka thanks! I'll try to do review on this week.

AHOHNMYC avatar Sep 10 '23 11:09 AHOHNMYC

This development is going on? :thinking:

tassoman avatar Dec 05 '23 21:12 tassoman

The development of this feature has concluded, but if you find some bugs , let me know,i will fix it.

bonjinnorenka avatar Dec 06 '23 22:12 bonjinnorenka

Was also merged to a stable release? I'm going to write a 3rd party code, based on this.
I can't say which version of invidious i need to rely on :thinking:

tassoman avatar Dec 07 '23 08:12 tassoman

This pull request isn't merged to stable release. So any version of invidious haven't this function now. Also I don't know when this marge to release. As far as I know I was done everything that I realized to do to merge this pull request.

bonjinnorenka avatar Dec 07 '23 08:12 bonjinnorenka

I hope can be merged soon, I find it very useful

tassoman avatar Dec 09 '23 02:12 tassoman

This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked.

github-actions[bot] avatar Mar 08 '24 12:03 github-actions[bot]

By merging this PR, Fediverse softwares user interfaces would be able to interact with the iframe player from invidious instances

tassoman avatar Mar 15 '24 14:03 tassoman

Does anyone have an alternative while this is being reviewed? I'm also waiting patiently :)

rbozan avatar Mar 21 '24 15:03 rbozan