invidious
invidious copied to clipboard
Show message when comments are turned off
Fixes: #1092 I want to be awarded the bounty associated to the issue this PR is fixing.
I've also added a message for when comments are disabled via Invidious config.
Tested and checked, works without problems. I haven't tested it on production but it works as is, no need to change settings. However i wasn't able to find the invidious config related to "added a message for when comments are disabled via Invidious config" but it works. Comments on videos WITHOUT comments disabled are displayed.
If anyone wants to test this in a debug/test instance it can be easily merged using this commands:
$ git fetch origin pull/4051/head:show-comments-turned-off-message
$ git merge show-comments-turned-off-message
$ make
I would add translations for es.json in this pull request but I don't know how to propose changes to a pull request
However i wasn't able to find the invidious config related to "added a message for when
Oops. I shouldn't have used the word config there. I meant when comments are disabled in Invidious's preferences.
See https://github.com/iv-org/invidious/issues/2585#issuecomment-1686633019 for how to do so. Its not very clear in the UI.
I would add translations for es.json in this pull request but I don't know how to propose changes to a pull request
Unfortunately Github only lets you suggest changes on lines near changes that occurred within the PR. If you'd like to add translations feel free to make a PR to the show-comments-turned-off-message branch on my fork here https://github.com/syeopite/invidious. It should get automatically included in this PR once merged.
This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked.