invidious
invidious copied to clipboard
Rewrite streams logic
WIP
This PR is meant to overhaul how the streams' data (formats
/adaptativeFormats
) is parsed.
Objectives:
- support videos with multiple audio tracks (#2007)
- provide a much more stable interface/API (#2513, #2647, #2988)
- Fix various audio issues (#597, #2393, #3600)
- Add mime types back to the DASH manifest on demand (#3342)
Here are some useful test videos for multi-audio tracks:
- https://youtu.be/YLt73w6criQ (english original + a lot of dubs)
- https://youtu.be/Kn56bMZ9OE8 (english original, english dubbed + english descriptive)
Also here is a video with missing attributes on some formats (AV1): https://youtu.be/8IFwpI7OT6I From https://github.com/FreeTubeApp/FreeTube/issues/3382
Would this fix https://github.com/iv-org/invidious/issues/3757?
Would this fix #3757?
No I don't think because no changes have been done to support browsers that don't support AV1 codec.
This supposedly covers one of the mentioned issues (the one that requests for webm streams to be added to the DASH manifest).
This supposedly covers one of the mentioned issues (the one that requests for webm streams to be added to the DASH manifest).
webm is not supported by videojs so that doesn't really impact the video player of invidious. this will still won't fix the issue on edge
Could you please include the bitrate for the formatStreams in the API, I know it's not used by Invidious, but it's returned by YouTube and I would like to display it in FreeTube's debug/stats overlay.
This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked.