Improve atom feeds

[SamantazFox]

Make the following changes to Atom feeds:

• Remove non-standard <yt:videoId> and <yt:channelId> elements
• Make entry IDs RFC compliant (must be an URI) => This should also prevent some web-based RSS readers from embedding the youtube player
• Base all URLs (icons, links, etc) on HOST_URL
• Fix the different problems reported by W3C validator

Notes:

• RSS feeds are TODO
• Player can't be embedded without breaking RFC compliance (See why in issues listed below)

Fixes #1064 Fixes #2248 Fixes #2249

[github-actions[bot]]

This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked.

[ghost]

Anything else to be done @SamantazFox ?

[SamantazFox]

@Loki-L1130 yes! See the .to_xml methods here and there? Those needs to be cleaned up and merged into a single function.

[ghost]

See the .to_xml methods here and there? Those needs to be cleaned up and merged into a single function.

Well, I presume, It would take about an Hour to fix though. I just made a comment because the Github bot marked it as stale and to close in 30 Days if without any activity. So, I did pinged you.

[SamantazFox]

See the .to_xml methods here and there? Those needs to be cleaned up and merged into a single function.

Well, I presume, It would take about an Hour to fix though. I just made a comment because the Github bot marked it as stale and to close in 30 Days if without any activity. So, I did pinged you.

yeah, the bot marks PRs as "stale" if there wasn't activity for 30 days. Don't worry, though, I see the notifications and remove the label in the ay after, or so. I'm just very busy IRL atm, so I haven't got the time to work on that feature.

[github-actions[bot]]

This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked.

[SamantazFox]

Deployed on test.invidious.io

[absidue]

Hiii As requested I'm leaving a comment here about this pull request requiring changes on the FreeTube side, as we use the <yt:videoId> elements, which are present in the YouTube feeds too. We currently use the same code to parse both the YouTube RSS and Invidious Atom feeds, however with this change we'll likely need to split up the parsing, to handle the two different feeds.

Please let us know when this pull request is ready to merge, so we can make the necessary changes on our side, thanks in advance :).

https://github.com/FreeTubeApp/FreeTube/blob/c2235ade8a66b7f0554d63ac8da59c7d26531ded/src/renderer/views/Subscriptions/Subscriptions.js#L433-L463

[github-actions[bot]]

This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked.