invidious icon indicating copy to clipboard operation
invidious copied to clipboard

[Bug] Livestreams aren't ended in the manifest

Open tenpura-shrimp opened this issue 4 years ago • 4 comments

It looks like currently there is no end element in the hls manifest, so videojs will keep polling the manifest for the next one, because it thinks the livestream is still happening

tenpura-shrimp avatar Feb 26 '21 06:02 tenpura-shrimp

I looked into this more. Seems like youtube never sends the stream ended tag in the manifest, which is a violation of the dash standard. Videojs understandably does not acccount for this.

I checked how it's done in streamlink and they simply have a timeout if the manifest is expired for too long. We can implement something similar for invidious. I can also check what newpipe does.

The other issue the the videojs polling interval for this, which is like 10x per second.

tenpura-shrimp avatar Feb 28 '21 14:02 tenpura-shrimp

This issue has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, you just have to post a comment and it will be unmarked.

github-actions[bot] avatar Aug 26 '22 12:08 github-actions[bot]

Still relevant?

SamantazFox avatar Sep 25 '22 19:09 SamantazFox

This is very relevant and cause useless requests because the videojs client will still try to continue fetching the video stream when the actual livestream has ended.

Alternative is to switch to DASH manifests for livestream.

unixfox avatar Feb 13 '23 09:02 unixfox