invidious icon indicating copy to clipboard operation
invidious copied to clipboard

[Bug] Playlists list continuation is broken

Open TheFrenchGhosty opened this issue 4 years ago • 12 comments

Clicking on "Next page" on the playlists list of a channel will trigger a bug, because the continuation is broken.

Example:

https://invidious.snopyta.org/channel/UCXuqSBlHAE6Xw-yeJA0Tunw/playlists

"Next page" continuation is ?continuation= instead of an actual value:

https://invidious.snopyta.org/channel/UCXuqSBlHAE6Xw-yeJA0Tunw/playlists?continuation=

TheFrenchGhosty avatar Dec 22 '20 18:12 TheFrenchGhosty

Updated example:

https://invidious.snopyta.org/channel/UC-lHJZR3Gqxm24_Vd_AJ5Yw/playlists

https://www.youtube.com/channel/UC-lHJZR3Gqxm24_Vd_AJ5Yw/playlists

TheFrenchGhosty avatar Feb 26 '21 20:02 TheFrenchGhosty

A 20$ bounty has been added to this issue.

Anyone opening a PR fixing this issue, will receive 20$ (in BTC) from the Invidious project.

More details: https://github.com/iv-org/invidious/issues/1898

TheFrenchGhosty avatar Mar 17 '21 17:03 TheFrenchGhosty

Is this bug still relevant? I just checked with the latest version from master and the "Next" button works on PewDiePie's playlists without problems. The API endpoint (http://localhost:3000/api/v1/channels/playlists/UC-lHJZR3Gqxm24_Vd_AJ5Yw?continuation=...) also seems to work ok.

greenfoo avatar Apr 04 '21 15:04 greenfoo

It is still relevant.

There's not next button here: https://invidious.snopyta.org/channel/UC-lHJZR3Gqxm24_Vd_AJ5Yw/playlists

TheFrenchGhosty avatar Apr 04 '21 16:04 TheFrenchGhosty

Snopyta is not using the latest commit from master: snopyta

I just tried with the latest master and the Next button is there: next

It looks like the commit where this issue was fixed is c0997f951c9af58a844d6098398ce0a39e43d052

greenfoo avatar Apr 04 '21 20:04 greenfoo

mmh great then!

Edit: I tried it still partially broken.

TheFrenchGhosty avatar Apr 04 '21 22:04 TheFrenchGhosty

It works on the few channels I tried, however, there is no "previous page" button.

As I mentionned in https://github.com/iv-org/invidious/pull/1929#issuecomment-812553482, the ctoken generation is still required for three reasons:

  1. Shorter links with a ?page=n parameter, easily human-readable
  2. Making sure that no tracking parameters are embedded in said token (this is big G, who knows what can happen).
  3. The user can sort the playlists differently than what youtube defaults to (last updated)

SamantazFox avatar Apr 06 '21 19:04 SamantazFox

It is not broken anymore

B0pol avatar Jun 24 '21 19:06 B0pol

@B0pol filters don't work. For instance, both of these return the same thing:

  • https://invidious.snopyta.org/channel/UC-lHJZR3Gqxm24_Vd_AJ5Yw/playlists?sort_by=newest
  • https://invidious.snopyta.org/channel/UC-lHJZR3Gqxm24_Vd_AJ5Yw/playlists?sort_by=oldest

SamantazFox avatar Jun 25 '21 08:06 SamantazFox

But then open an issue for filters, and close this one about continuation

B0pol avatar Jun 25 '21 08:06 B0pol

Also, there is no "previous page" button

SamantazFox avatar Jun 25 '21 12:06 SamantazFox

This issue has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, you just have to post a comment and it will be unmarked.

github-actions[bot] avatar Jul 29 '22 12:07 github-actions[bot]