invidious
invidious copied to clipboard
iv-org
Make number of columns in feed customizable
Closes #1018. Add a new preference feed_cols and use it to determine the width of each video relative to the feed.
Please note that this only works when the value of feed_cols is a factor of 5 or 24, because of the way that Pure CSS's grid system works. If it would be beneficial to give the user a warning or to reject invalid inputs instead of blindly following the user's request (which would cause the number of columns to be effectively 1), I could also implement that.
Wouldn't it be better to allow only a specific number of columns (let's say from 3 to 10) and then map that to pre-defined pure-g classes? Less hassle for the user or instance owner, and it makes sure that we won't have weird results.
In essence:
-
3=>pure-g-*-1-3 -
4=>pure-g-*-1-4 -
5=>pure-g-*-1-5 -
6=>pure-g-*-1-6 -
7=>pure-g-*-3-24(as this one must be approximated, maybe don't propose it?) -
8=>pure-g-*-1-8
And also, please add your translation key to ALL locales files. I spent a few days doing #1920, I don't want to do it again! And it also helps translators by showing them an "untranslated string" in weblate!
@SamantazFox Thank you for your review. I just rebased my branch on the latest master and adapted to changes made over the past year, and I also added the translation key to the rest of the locale files. I'll test my rebased changes and respond to your other comment some time soon, after I sort out an issue with Docker and get Invidious to start properly.
@TheFrenchGhosty Could you please request a review from @saltycrys for this PR? Thanks
Just tested and it works perfectly! I just have one small concern. Since a column size of 7 isn't supported, would it be possible to add a warning about that?
This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked.
This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked.
This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked.
This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked.
This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked.
This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked.