documentation icon indicating copy to clipboard operation
documentation copied to clipboard

[Discussion] Consider recommending Libredirect instead of Privacy Redirect

Open TheFrenchGhosty opened this issue 3 years ago • 2 comments

Half enhancement, Half discussion

We're looking for user opinions, feel free to reply to this issue, or to the associated toot: https://social.tchncs.de/@invidious/107791413111817572

Is your enhancement request related to a problem? Please describe.

We currently endorse, and even recommend Privacy Redirect, however the project is basically dead, and unmaintained.

Describe the solution you'd like

We can instead recommend Libredirect: https://github.com/libredirect/libredirect

Describe alternatives you've considered

We take over (or fork) Privacy Redirect, this is not a really good idea considering we already have stuff to work on, and I don't think anyone in the team is a "good" JS developer.

Additional context

Libredirect has multiples issue:

@SimonBrazell is against the fork: https://github.com/SimonBrazell/privacy-redirect/pull/319#issuecomment-987361792

No one currently uses it (15 users according to https://addons.mozilla.org/en-US/firefox/addon/libredirect/ )

We had a discussion in the offtopic room a while ago, some useful information/points:

1 2

TheFrenchGhosty avatar Feb 13 '22 15:02 TheFrenchGhosty

Libredirect is actively maintained with a lot more features and more frontend redirects than Privacy Redirect, also the developers have been really quick to respond to any issues, and have been working really quick to redesign and improve Privacy Redirect, so they have earned my trust despite their short time on GitHub, so I think this should be implemented

davidcollini avatar Feb 26 '22 15:02 davidcollini

@SimonBrazell is against the fork: https://github.com/SimonBrazell/privacy-redirect/pull/319#issuecomment-987361792

Many of the changes we made won't make @SimonBrazell happy. I'll just fight with him a lot even about the code organization and structuring scheme. He's also busy and there's no time to wait for an approval to a PR. Either he let me be an admin on PrivacyRedirect (which is just an occupation of his own project. He also doesn't really know me so he won't be able to trust me) or fork it with peace and everyone takes his path. As I'm adding and committing new fixes and features to LibRedirect, I really don't regret that we forked it as it was the right choice.

No one currently uses it (15 users according to https://addons.mozilla.org/en-US/firefox/addon/libredirect/ )

Well today my friend we've exceeded 1k active users on Firefox! and it's still growing. You know the feeling when you see your child grow 🥰

We added almost all invidious settings too. This will help a lot in making the use of multiple instances consistent and therefore reduce the load on popular ones: invidious-settings

ManeraKai avatar Mar 13 '22 16:03 ManeraKai

Follow up to a Matrix discussion where I was asked by Hygna what was needed for us to recommend Libredrect officially, here's a list (@SamantazFox @unixfox @Perflyst feel free to add your input):

  • Make a page like invidious.io/team/ (Hygna is currently the main dev, but has basically no permission - other than "owner" in the Codeberg organisation)
  • Build the Mozilla releases with CI
  • Don't have a single person receive the money
  • Figure out who own the project, and mark it as such (in the team page)
  • Hygna has to be added as an owner to the Mozilla page (not applicable if it's decided that he isn't an owner)
  • Centralize the issues/PR in one place, so that audits/checks don't have to be done in multiple places
  • Have a single website instead of 2 https://libredirect.codeberg.page/ https://libredirect.github.io/ - ideally on your own domain (after discussing it, I checked, and you did receive more than 15$ in donations so you can afford it)
  • Write proper credit/licensing information (on the website and in the addon itself), this isn't enough, and it's borderline GPL violation: image
  • Ask SimonBrazell what he plan to do with Privacy Redirect, if nothing, ask him to deprecate it
  • Be more transparent about what you do and with the project you're sending users to
  • Deprecate the dead software/instances (Bibliogram and all the "offline" instances for example)
  • Stop the trademark infringement ASAP (you have no rights to at least 2/3 of those logo)

TheFrenchGhosty avatar Oct 28 '22 14:10 TheFrenchGhosty

Hygna's replies (he doesn't have a Github account):

image

image

image

TheFrenchGhosty avatar Oct 28 '22 14:10 TheFrenchGhosty

Centralize the issues/PR in one place, so that audits/checks don't have to be done in multiple places

We are trying to reach as much users as possible. We will stay like this with two repos.

Have a single website instead of 2 https://libredirect.codeberg.page/ https://libredirect.github.io/ - ideally on your own domain (after discussing it, I checked, and you did receive more than 15$ in donations so you can afford it)

No need for a domain name for a small project like this. Those are just mirrors of each other it's not a problem.

ManeraKai avatar Oct 29 '22 13:10 ManeraKai

Deprecate the dead software/instances (Bibliogram and all the "offline" instances for example)

We won't. We already discussed about bibliogram and agreed to keep it for some people that want it.

ManeraKai avatar Oct 29 '22 13:10 ManeraKai

Ask SimonBrazell what he plan to do with Privacy Redirect, if nothing, ask him to deprecate it

No need for that.

ManeraKai avatar Oct 29 '22 15:10 ManeraKai

Write proper credit/licensing information (on the website and in the addon itself), this isn't enough, and it's borderline GPL violation:

We have the exact same license as Privacy Redirect and it's already in the repo's files. Nothing else is needed.

ManeraKai avatar Oct 29 '22 15:10 ManeraKai

Due to the fact that:

The fact that I even had to make a list because the Libredirect team can't do it themselves isn't really showing anything good, Libredirect is currently badly managed and the fact that their team can't agree with what should be done (or even come to discuss it - except for Hygna) isn't a good sign.

Libredirect won't be recommended by us anytime soon, it has FAR too much issues (especially in the management part), and is FAR too amateurish for us to send thousands/tens of thousands of users to it.

Hygna is basically stuck because he wants to do what I asked but @ManeraKai refuses. I personally STRONGLY recommend Hygna to fork Libredirect if he really cares that much. (I wasted hours discussing it with Hygna, I hope some good come out of this)

TheFrenchGhosty avatar Oct 29 '22 15:10 TheFrenchGhosty