ette icon indicating copy to clipboard operation
ette copied to clipboard

Use verbose strings on `EtteMode` configuration, instead of integers

Open arnaldopereira opened this issue 3 years ago • 2 comments

This change updates both the code and also the README. Beware that it does not add any test yet and it contains another change ahead of itzmeanjan/ette.

arnaldopereira avatar Jun 22 '21 15:06 arnaldopereira

Hello, thanks for PR. I think it's better to do a regex matching than case sensitive string matching.

itzmeanjan avatar Jun 23 '21 03:06 itzmeanjan

If we use a regex, shouldn't we use it on the configuration keys too? IMO the configuration could be strict enough to accept specific values (ie: not a regular expression) and have a sanity check, to validate the config and bails on bootstrap.

arnaldopereira avatar Jul 02 '21 13:07 arnaldopereira

I've stopped maintaining ette, so closing this PR. Thanks.

itzmeanjan avatar Jan 13 '23 12:01 itzmeanjan