Vanilla tweaks download only partial contents from the spec file and does not warn/errors

[ronoaldo]

It happened to me twice and the symptom seems to be when a new update to the VT packages arises. I have my server restarting every day (to ensure updates are fetched regularly from loder/mods/datapacks).

For two times now, it happened to me that the datapacks were partially downloaded, and some of the packs were then missing. No errors during startup or warnings, just a message stating that it was remofing old files. Not sure if some state got lost (perhaps the manifest)...

The server proceeds to load and shows in logs that missing datapacks are there. This could even corrupt some of the world state, depending on the pack; for instance, if custom nbt is improperly handled without the packs present (like the graves datapack).

I'm not sure if my stragey is wrong, if there is a better aproach let me know. Maybe I should be downloading the updates to a separate folder and merge with the ./data one?

Having an option to do not load if not all packs from the json file are present would be great.

Here are my current docker compose file:

services:
  mc:
    image: itzg/minecraft-server
    stdin_open: true
    tty: true
    environment:
      EULA: "true"
      TYPE: "FABRIC"
      VERSION: "1.21.7"
      MODRINTH_PROJECTS: "@/custom/mods.txt"
      VANILLATWEAKS_FILE: /custom/vanillatweaks.json
      REMOVE_OLD_DATAPACKS: false
      REMOVE_OLD_DATAPACKS_EXCLUDE: '*/ExpandedItems*'
      INIT_MEMORY: 1G
      MAX_MEMORY: 3G
      USE_AIKAR_FLAGS: true
      SEED: "2786386421968123439"
      SPAWN_PROTECTION: 0
      ENFORCE_SECURE_PROFILE: "false"
      PVP: "false"
      SERVER_NAME: Neptune
      RESOURCE_PACK: http://localhost:8081/ExpandedItems-resourcepack.zip
      RESOURCE_PACK_ID: 20135de1-8a88-4424-b764-5c224a38a0ab
      ICON: /custom/logo_256x256.png
      OVERRIDE_ICON: true
      RCON_CMDS_STARTUP: |-
        scoreboard players set stopsound timber 1
      UID: 1000
      GID: 1000
      DIFFICULTY: hard
    ports:
      - "25565:25565"
      - "19132:19132/udp"
    volumes:
      - ./data:/data
      - ./custom:/custom
    restart: unless-stopped

  dl:
    image: nginx
    volumes:
      - ./custom/:/usr/share/nginx/html
    ports:
      - "8081:80"
    restart: unless-stopped

Here is my mods and datapacks spec files:

  "type": "datapacks",
  "version": "1.21",
  "packs": {
    "decorative-cosmetic": [
      "custom nether portals",
      "name colors",
      "player head drops",
      "more mob heads"
    ],
    "convenience": [
      "unlock all recipes",
      "timber",
      "more effective tools",
      "elevators",
      "ender chest always drops",
      "dragon drops",
      "double shulker shells",
      "chunk loaders",
      "painting picker"
    ],
    "gameplay-changes": [
      "graves",
      "confetti creepers",
      "silk touch budding amethyst",
      "xp bottling",
      "armored elytra",
      "husks drop sand"
    ],
    "informative": [
      "coordinates hud",
      "durability ping",
      "villager death messages",
      "nether portal coords"
    ]
  }
}

fabric-api:release
geyser:beta
floodgate:release
hurricane:5pD5TgTl
craterlib:release
sdlink:release
lithium:release
anti-xray:release
pvp-toggle-mod:release
mine-spawners:release
datapack:attract-villagers:release

[itzg]

Thanks for reporting this and providing all the info to investigate. I also didn't expect it to continue on a partial failure, so that's something I need to fix.