docker-minecraft-server icon indicating copy to clipboard operation
docker-minecraft-server copied to clipboard

Download default configs when deploying Purpur and Pufferfish

Open Krymonota opened this issue 1 year ago • 1 comments

Enhancement Type

Improve an existing feature

Describe the enhancement

Since Purpur and Pufferfish are forks of Paper, it would be nice to download the same default configurations as for Paper. They are compatible because Purpur and Pufferfish have separate configuration files (purpur.yml / pufferfish.yml) for fork-specific features.

Essentially, we would simply have to extract this code into a reusable function/script and invoke it from start-deployPaper, start-deployPurpur and start-deployPufferfish. https://github.com/itzg/docker-minecraft-server/blob/621bafb4f257da547a0e5837ad4400833fcee345/scripts/start-deployPaper#L45-L56

And we would have to think about what to do with this environment variable (keep the same name for forks, rename it, ...?): https://github.com/itzg/docker-minecraft-server/blob/621bafb4f257da547a0e5837ad4400833fcee345/scripts/start-deployPaper#L13

Krymonota avatar Jan 02 '25 12:01 Krymonota

Great suggestions.

Perhaps for the variable it should be shifted to just CONFIG_DEFAULTS_REPO and used for all of them. The downside I can think is now it could seem applicable to non-Paper derivatives.

itzg avatar Jan 02 '25 13:01 itzg