docker-minecraft-server icon indicating copy to clipboard operation
docker-minecraft-server copied to clipboard

Published 20 hours ago • verified publisher icon itzg

Remove old files

Open ChipWolf opened this issue 2 years ago • 2 comments

Enhancement Type

Improve an existing feature

Describe the enhancement

Currently, REMOVE_OLD_MODS only targets the mods and plugins directory.

https://github.com/itzg/docker-minecraft-server/blob/46a09ed33103074f9c956a8cdf08bed564e40738/scripts/start-setupModpack#L19-L23

I propose we rename the variable to REMOVE_OLD_FILES and allow the REMOVE_OLD_FILES_INCLUDE to contain the path globs the user wishes to remove.

ChipWolf avatar Nov 10 '22 13:11 ChipWolf

I like the idea of a broader option, but am unsure if it should replace REMOVE_OLD_MODS. Other than being yet another variable, any problems you can see with having that as an option alongside the other?

itzg avatar Nov 10 '22 14:11 itzg

I like the idea of a broader option, but am unsure if it should replace REMOVE_OLD_MODS. Other than being yet another variable, any problems you can see with having that as an option alongside the other?

None in mind, I imagine supporting the [deprecated] operation, specifying REMOVE_OLD_MODS would just populate REMOVE_OLD_FILES_INCLUDE with the old defaults or something.

ChipWolf avatar Nov 13 '22 19:11 ChipWolf