Geoff Bourne
Geoff Bourne
Sorry, that now sounds like something that is beyond my knowledge or control.
Seems like it would be the indirect dependency here: https://github.com/itzg/mc-monitor/blob/3c931ec973e78ac576395043a27cd7f917f93ee4/go.mod#L52 I would have expected dependabot to already be addressing that on the next round. Are you really wanting to chase...
Thanks @vitorvasc ! I'm actually curious if the weekly run of dependabot (on Mondays for this repo) will bump that anyway.
Can you make sure you have pulled the latest image? I seem to remember that was already changed a while ago. Yeah in #220 ...unless they already changed it again
Yes it's a good request. Some web servers certainly fallback to octet stream for zip files.
You might be overthinking it 😄 If the downloaded file is not a proper zip file, then the zip file extraction will fail since it itself will perform file/header inspection....
...and now that I look at the source code closer, it's using a file inspection: https://github.com/itzg/docker-minecraft-server/blob/dcdbb85936ebc7b28d6d4ef5c893043c18f5bf96/scripts/start-utils#L425 to determine the content of the file and has nothing to do with what...
Ah, the alpine aspect was important. In the spirit of being minimal, some of their commands are reimplemented to the point of being incomplete (i.e. broken). Other than quick one-off...
https://github.com/itzg/docker-minecraft-server/blob/dcf2f46620afbdf0193716d46525228fbcd97fef/scripts/start-utils#L421-L441 needs to be refactored to conditionally look at filename extension when `getDistro` reports alpine.
1.21.5 is still considered experimental by PaperMC  https://papermc.io/downloads/paper Paper Downloads | PaperMC Refer to the docs https://docker-minecraft-server.readthedocs.io/en/latest/types-and-platforms/server-types/paper/#:~:text=To%20allow%20for%20the%20selection%20of%20experimental%20builds%2C%20set%20PAPER_CHANNEL%20to%20%22experimental%22