react-native-video-controls icon indicating copy to clipboard operation
react-native-video-controls copied to clipboard

Published 20 hours ago • verified publisher icon itsnubix

feat: add typescript declaration.

Open kuasha420 opened this issue 4 years ago • 4 comments

Hello,

Thank you for the great library. I've added typescript declaration for it.

Let me know if anything else needs changing.

Best Regards.

Arafat

kuasha420 avatar Mar 19 '21 19:03 kuasha420

nice

GolfredoPerezFernandez avatar May 04 '21 01:05 GolfredoPerezFernandez

@itsnubix I've fixed the conflict. Can this get merged?

Thanks.

kuasha420 avatar Jun 01 '21 10:06 kuasha420

Bunch of questions here...firstly wth is a DuckNavigator lol.

kylemilloy avatar Jun 11 '21 16:06 kylemilloy

@kylemilloy I'd be happy to answer all the questions you have.

firstly wth is a DuckNavigator lol.

This codebase only cares if the navigation object has a pop method and uses it. Many implementation of a navigator may have it, including @react-navigation/stack, react-native-screens/native-stack and react-native-navigation. So we only care of the passed navigation object has the pop method hence the DuckNavigator (reference to Duck Typing Practices).

Regards.

kuasha420 avatar Jun 11 '21 17:06 kuasha420

@kylemilloy can you please marge this?

FezMLG avatar Oct 22 '22 13:10 FezMLG