react-native-video-controls icon indicating copy to clipboard operation
react-native-video-controls copied to clipboard

check for and set rate prop update in componentWillReceiveProps

Open joeyscarim opened this issue 5 years ago • 1 comments

the rate prop was not updating when passing a new value to it, as referenced here: https://github.com/itsnubix/react-native-video-controls/issues/101#issuecomment-427805544

This fixes that issue, in the same way that the pause prop is handled

joeyscarim avatar Feb 27 '20 21:02 joeyscarim

I'd prefer us to remove UNSAFE functions entirely which will likely be removed in newer versions in favour of getDerivedStateFromProps or similar lifecycle methods.

kylemilloy avatar Jul 08 '20 15:07 kylemilloy