betteranimalsplus icon indicating copy to clipboard operation
betteranimalsplus copied to clipboard

[Forge 1.16.5] Right clicking reindeer with jar from Supplementaries teleports you

Open antibang opened this issue 2 years ago • 3 comments

Describe the bug

So, I'm not sure who to report this to, but if you right-click a reindeer with a jar from Supplementaries, it jars the entity, but it sends you to 0, 2, 0 in the world. Which then leads to suffocation if you're not speedy enough lol

The jarring of all entities isn't a feature enabled by default, so it's been changed in the Supplementaries config. This doesn't happen with any other mob

As for the wolf bug (which is not too important, but I'm just generally interested): on my server, visually all the wolves are the black variant, but still drop different colored pelts. This does not happen in singleplayer.

If you'd like some more logs, just let me know, I just wasn't sure if they'd be useful in this situation and I have yet to look at them myself because tired :(

To Reproduce

Steps to reproduce the behavior:

  1. Right-click a reindeer with a jar
  2. Be sent to 0, 2, 0

Log output/error (if present)

latest.log

Expected behavior

Be able to right-click a reindeer with a jar without being teleported to 0, 2, 0

Screenshots

Versions

  • Minecraft Version: 1.16.5
  • Architectury API Version: 1.28.48
  • Platform (Forge/Fabric): Forge
  • Forge Version: 32.2.20
  • Fabric Loader Version: -
  • Fabric API Version: -
  • Mod Version: 11.0.5

Additional context

antibang avatar Mar 19 '22 23:03 antibang

See #294 (closed due to lack of info) for additional wolf bug information. Likely caused by shaders or Optifine, alternatively a mod mismatch between client/server causing variant data to not sync properly, I have yet to determine a mod responsible.

Are you able to send both a client and server log? This would maybe help me diagnose a data sync mismatch.

I think I may have found the source, I mistakenly left a feral wolf reference in the coyote datamanager when separating the two entities' class hierarchies.

https://github.com/itsmeow/betteranimalsplus/blob/3317be85a55932941eb7a8cc91d8d15dabffac59/common/src/main/java/dev/itsmeow/betteranimalsplus/common/entity/EntityCoyote.java#L63

itsmeow avatar Mar 21 '22 15:03 itsmeow

As for supplementaries, it might be that the interaction event is still occuring and the player attempts to mount the reindeer as it serialized (and therefore its position is 0,0,0)

itsmeow avatar Mar 21 '22 15:03 itsmeow

Sorry for the late reply, but here is my most recent log from the server: latest.log

Here's my most recent client log: latest.log

antibang avatar Mar 22 '22 16:03 antibang