ICGVideoTrimmer icon indicating copy to clipboard operation
ICGVideoTrimmer copied to clipboard

Porting to Swift

Open martyu opened this issue 5 years ago • 5 comments

I don't think github has a "discussion" secion, so I'm putting this here...

The Objective-C-ness of this is driving me crazy. And to a lesser extent, the non-autolayout-ness. I'm rewriting to Swift in a...new project I guess? I guess it doesn't make sense to fork it since it will be all new code? Has anyone already done this, or is there any reason I shouldn't?

martyu avatar Nov 18 '18 19:11 martyu

Hi, I don't think anyone did that - so please feel free to port it to swift. I can help with that too if you need another hand!

itsmeichigo avatar Nov 19 '18 02:11 itsmeichigo

Sweet I’ll send you the PR. Also going to see if I can work in autolayout. Or at the very least refactor out that ‘resetSubviews’ method. Seems like most of it could be moved to ‘init’ and ‘layoutSubviews’

martyu avatar Nov 19 '18 03:11 martyu

Yes I agree that autolayout would be great and should be used instead of my current messy screen size calculation. But are you putting the swift code in this same repo? I think a separate repo would be neater.

itsmeichigo avatar Nov 19 '18 06:11 itsmeichigo

Yeah that's why I was saying it probably wouldn't be good to fork it even. I guess it would be a new repo and I would just link back to this repo in the Readme for reference?

martyu avatar Nov 20 '18 01:11 martyu

Yes that works - let me know if you need any help.

itsmeichigo avatar Nov 20 '18 01:11 itsmeichigo