SIEdit icon indicating copy to clipboard operation
SIEdit copied to clipboard
verified publisher icon itsmattkc

Fix building of libweaver under MSYS2

Open zulc22 opened this issue 1 year ago • 2 comments

NOMINMAX is actually defined in MSYS2's headers, so I added #IFNDEF to guard defining NOMINMAX if it was already defined.

zulc22 avatar Oct 30 '24 02:10 zulc22

i found another issue with MSYS2. si::File doesn't properly get a handle for a binary file on MSYS2 (using UCRT64 GCC). it does a line-ending conversion. for some reason, SIEdit compiled via MSYS2 is able to extract files perfectly fine despite this. does SIEdit never use *Object->ExtractToFile()?

zulc22 avatar Oct 30 '24 06:10 zulc22

In #38 I addressed NOMINMAX from cmake.

madebr avatar Oct 24 '25 17:10 madebr