clockwork icon indicating copy to clipboard operation
clockwork copied to clipboard

JsonResponse not getting correct header

Open FredrikPAC opened this issue 2 years ago • 1 comments

I have an error with the following: On line 428 it checks if the response is an instance of a Illuminate\Http\Response making all responses that are Illuminate\Http\JsonResponse fail. Could this be changed to the more core Symfony\Component\HttpFoundation\Response instead?

https://github.com/itsgoingd/clockwork/blob/1a5ad0fc8e632b0e7c21291717d4ebff77ccc7e8/Clockwork/Support/Laravel/ClockworkSupport.php#L427-L439

FredrikPAC avatar Aug 30 '23 21:08 FredrikPAC

Hey, sorry I missed this issue somehow. I think this is intentional, as the toolbar does not really work for api responses atm.

itsgoingd avatar Feb 21 '24 20:02 itsgoingd