clockwork icon indicating copy to clipboard operation
clockwork copied to clipboard

Session data display in extensions: binary data shown as 'null'

Open tminich opened this issue 5 years ago • 2 comments

If you have binary data in your session both Firefox and Chrome extensions show it as 'null' in the Request section. I don't expect it to be actually displayed, but it would be nice to see something like '<Binary Data (Length 64)>' or similar instead as 'null' is quite misleading.

tminich avatar Feb 03 '20 14:02 tminich

Interesting, we already have a code that stores binary database bindings in hex format

https://github.com/itsgoingd/clockwork/blob/master/Clockwork/DataSource/EloquentDataSource.php#L175

I guess we could use a similar code when serializing data globally. I'm a worried about the performance impact of running preg_match possibly hundreds or thousands of times though. Will need to investigate more.

itsgoingd avatar Feb 03 '20 14:02 itsgoingd

Well, for me personally the data itself doesn't really matter, I'd just like a 'something there' instead of 'null' =)

tminich avatar Feb 03 '20 14:02 tminich