DataMonitor icon indicating copy to clipboard operation
DataMonitor copied to clipboard

Upload to F-Droid

Open xmha97 opened this issue 1 year ago • 10 comments

Please update this app to F-Droid and then put a link below on README.md

https://f-droid.org/packages/com.drnoob.datamonitor/

xmha97 avatar Aug 01 '22 04:08 xmha97

I'm currently working on pushing the app to play store. Will surely consider F-Droid as well

itsdrnoob avatar Aug 01 '22 12:08 itsdrnoob

Currently available on IzzyOnDroid repo: https://apt.izzysoft.de/fdroid/index/apk/com.drnoob.datamonitor According to izzy's scanner it has GMS proprietary library. Screenshot_2022-08-08-13-53-21

shuvashish76 avatar Aug 08 '22 08:08 shuvashish76

According to izzy's scanner it has GMS proprietary library

I didn't see that coming.

itsdrnoob avatar Aug 08 '22 10:08 itsdrnoob

I'm currently working on pushing the app to play store. Will surely consider F-Droid as well

As I see it's live on Playstore, any plans for F-Droid?

RFP: https://gitlab.com/fdroid/rfp/-/issues/2165

shuvashish76 avatar Aug 14 '22 14:08 shuvashish76

I didn't see that coming.

I did. Need help? Culprit most likely is Google OSS Licenses plugin, which is known to drag that in as a dependency. See my snippet here for details and potential alternatives.

IzzySoft avatar Aug 14 '22 19:08 IzzySoft

Culprit most likely is Google OSS Licenses plugin

I thought OSS plugin was seperate from other core GMS libs. I'll replace it with an alternative as you mentioned in the snippet. Appreciate your help.

itsdrnoob avatar Aug 15 '22 01:08 itsdrnoob

I thought OSS plugin was seperate from other core GMS libs.

Many thought so. And its name (carrying the term "OSS") with the plugin being Apache-2.0 licensed suggests as much. But we had it so many times already. No idea why (i.e. what for), but it drags in non-free deps (here: GMS). You can check for yourself to make sure: gradle :app:dependencies should give you the dependency tree.

IzzySoft avatar Aug 15 '22 06:08 IzzySoft

You can check for yourself to make sure

Just checked the dependency tree, OSS plugin indeed has other GMS modules bundled within.

itsdrnoob avatar Aug 15 '22 07:08 itsdrnoob

@IzzySoft GMS removed, but still shows "Anti-Features" tag on your repo.

shuvashish76 avatar Sep 03 '22 07:09 shuvashish76

NonFreeDep is one of the AFs that need manual care. Thanks for the notification – checked and removed the AF. Will take effect with the next sync today around 6 pm UTC then.

IzzySoft avatar Sep 05 '22 06:09 IzzySoft

What is the update on this issue?

jcperil avatar Sep 29 '22 19:09 jcperil

What is the update on this issue?

No updates yet, ig I've to manually issue a PR in the fdroiddata repo.

itsdrnoob avatar Sep 30 '22 04:09 itsdrnoob

That would speed things up indeed. For starters, here comes a template for metadata/com.drnoob.datamonitor.yml you could start with:

Categories:
  - Internet
  - System
License: GPL-3.0-only
AuthorName: Dr.NooB
AuthorEmail: [email protected]
WebSite: https://forum.xda-developers.com/t/app-v1-0-data-monitor-track-all-your-data-usage-at-one-place.4356129/
SourceCode: https://github.com/itsdrnoob/DataMonitor
IssueTracker: https://github.com/itsdrnoob/DataMonitor/issues
Changelog: https://github.com/itsdrnoob/DataMonitor/releases

AutoName: Data Monitor

RepoType: git
Repo: https://github.com/itsdrnoob/DataMonitor

Builds:
  - versionName: v2.0.0
    versionCode: 7
    commit: v2.0.0
    subdir: app
    sudo:
      - apt-get update || apt-get update
      - apt-get install -y openjdk-11-jdk-headless
      - update-alternatives --auto java
    gradle:
      - yes

AutoUpdateMode: Version
UpdateCheckMode: Tags
CurrentVersion: v2.0.0
CurrentVersionCode: 7

Depending on the pipeline results, some adjustments might be needed – but if you're lucky it works out-of-the-box.

IzzySoft avatar Sep 30 '22 17:09 IzzySoft

@IzzySoft Will make the necessary adjustments. Thanks for the template by the way.

itsdrnoob avatar Oct 01 '22 04:10 itsdrnoob

Gladly – and :crossed_fingers: for a smooth walk!

IzzySoft avatar Oct 01 '22 11:10 IzzySoft

Live on F-Droid: https://www.f-droid.org/packages/com.drnoob.datamonitor/ 🎉

shuvashish76 avatar Oct 28 '22 22:10 shuvashish76

Well, time to close this issue as completed now :)

itsdrnoob avatar Oct 29 '22 03:10 itsdrnoob