DataMonitor icon indicating copy to clipboard operation
DataMonitor copied to clipboard

Enhancement/kotlin transition

Open yatiksihag01 opened this issue 2 years ago • 3 comments

This PR extends #190 which was closed due to change in base branch. This PR also solved all the unexpected behaviour mentioned here.

yatiksihag01 avatar Sep 06 '23 14:09 yatiksihag01

Great, most of the previous issues were addressed but I've still noticed some issues.

  • The System apps list gets refreshed upon opening and requires additional refresh to update values on session change or after refreshing the main list. Presumably due to the shift of data loading to AppDataUsageFragment.
  • Due to the shift, the data is refreshed only on navigating to the fragment, adding to an increase in loading time.
  • I've also noticed that the data is refreshed on every navigation, causing a lag/delay while navigating to the fragment.

Let me know what you think.

itsdrnoob avatar Sep 10 '23 13:09 itsdrnoob

requires additional refresh to update values on session change or after refreshing the main list

Hi @itsdrnoob , can you please explain a bit about first issue?

yatiksihag01 avatar Sep 11 '23 16:09 yatiksihag01

Hi @itsdrnoob , can you please explain a bit about first issue?

Sure. So basically both user app list as well as system apps list has to be refreshed on events like manual refresh in AppDataUsageFragment and session/type filter change, so that if opened, the up-to-date data is readily available in SystemDataUsageFragment. This was done by accessing the AppDataUsageFragment.mSystemList.

Also, here are some other details I've observed

  • On changing the filter from a session/type which is empty, the loading shimmer is not shown from there after.
  • The background time seems inaccurate. It will sometimes show the same value as screen time (when it's different) or shows 0.
  • Another minute detail, on changing the session, the recyclerView position stays the same (should scroll to the top).

itsdrnoob avatar Sep 12 '23 02:09 itsdrnoob