koji icon indicating copy to clipboard operation
koji copied to clipboard

Fails to build with cocogitto

Open berkus opened this issue 10 months ago • 0 comments

Describe the bug

Fails to build with latest cocogitto:

   Compiling cocogitto v6.1.0
   Compiling koji v2.2.0
error[E0061]: this method takes 1 argument but 7 arguments were supplied
  --> /Users/berkus/.cargo/registry/src/index.crates.io-6f17d22bba15001f/koji-2.2.0/src/lib/commit.rs:44:15
   |
44 |     cocogitto.conventional_commit(
   |               ^^^^^^^^^^^^^^^^^^^
45 |         &commit_type,
   |         ------------ expected `CommitOptions<'_>`, found `&String`
   |
note: method defined here
  --> /Users/berkus/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cocogitto-6.1.0/src/command/commit.rs:24:12
   |
24 |     pub fn conventional_commit(&self, opts: CommitOptions) -> Result<()> {
   |            ^^^^^^^^^^^^^^^^^^^
help: remove the extra arguments
   |
45 -         &commit_type,
45 +         /* CommitOptions<'_> */,
   |

For more information about this error, try `rustc --explain E0061`.
error: could not compile `koji` (lib) due to 1 previous error

To Reproduce

cargo +nightly install koji

Expected behavior

Koji should install.

Additional context

Not sure when cocogitto changed this interface, but it seems like they broke API between 6.0 and 6.1. Koji should probably depend strictly on 6.0 or upgrade the dep to 6.1.

berkus avatar Apr 13 '24 05:04 berkus