itowlson

Results 479 comments of itowlson

I don't have an opinion on the existence of the file, but I have some concerns about requiring contributors to maintain it as they go: 1. We already have a...

I think none of your patterns cover `spin.toml` - your wildcard is `*/*` which I would expect to cover subdirectories only. But `spin.toml` should be watched anyway. A component shouldn't...

I don't see anything checking for `!` patterns unless it's already handled by the `watchexec` glob filter. But there's a separate checker for `spin.toml` which should be reloading when that...

Huh. Seems like the `!` prefix does work. I better claim this as an achievement quick.

Okay _something_ weird is going on with `spin.toml`. Also, the magic exclude is actually a problem, because we use a single watcher for globs, meaning the lists get combined. Consider...

The exclamation mark syntax isn't mentioned in the docs for watchexec (https://watchexec.github.io/docs/glob-patterns.html) or the underlying glob library (https://docs.rs/globset/latest/globset/). And the globset filterer docs have a separate parameter for providing exclusions...

`watchexec --filter-file` also allows (undocumented?) for the `!` syntax and passes it unmodified into `GlobsetFilterer` so here we are I guess.

Okay the situation with `spin.toml` is a bit more nuanced than it appeared. We _do_ still monitor for changes in `spin.toml` so that we can reconfigure the watchers on a...

@mikkelhegn Please give the latest Spin build a test and let me know if you run into any weirdness with the `!` syntax. We have not done anything to enable...

okay nobody has shrieked at me about #2554 not working so gonna MASH THAT CLOSE BUTTON