Wilfried Chauveau

Results 84 comments of Wilfried Chauveau

Migration to `portable-atomic` (plus a few other tiny changes) in https://github.com/jamesmunns/bbqueue/pull/103

Is the ci failure related to the changes in this PR?

It is not stale. To summarize the pending thread: - @JakobLichterfeld does not want to see a hard codded value for the `vehicle_id` - This `vehicle_id` is not exported in...

Still waiting far input from reviewer.

I discovered today that `_ = …` is a valid alternative to `let _ = …`. Personally, I tend to prefer the lighter `_ = …`. However, I can see...

I’ll keep it as `let _ = `. I don’t think having a different recommendation based on the compiler version in used is a great things. The noise caused would...

@y21 & @flip1995 is there anything blocking the PR from making it through?

That should do the trick (I also rebased on top of master).

@y21, I squashed the commits together and kept the relevant commit title.